Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a card in Text Formatting - Text Tune #2199

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

nelsonuprety1
Copy link
Contributor

Fixes Issue

Closes #2197

Changes proposed

Screenshots

Note to reviewers

Copy link

vercel bot commented Dec 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2023 5:53pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, nelsonuprety1, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@nelsonuprety1
Copy link
Contributor Author

CBID2
CBID2 previously approved these changes Dec 1, 2023
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a subcategory with text-formatting.

image

You need to add files as per contributing guidelines, just adding a json file won't create a subcategory.

@nelsonuprety1
Copy link
Contributor Author

@Anmol-Baranwal I have fixed the issues and added the subcategory properly. Please kindly check this PR thank you.
Screenshot 2023-12-01 at 23 03 51

Anmol-Baranwal
Anmol-Baranwal previously approved these changes Dec 3, 2023
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

Thanks for the changes :)

@rupali-codes @aftabrehan @CBID2 Please review :)

Copy link
Collaborator

@aftabrehan aftabrehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nelsonuprety1, Thanks for the contribution. It could be useful.

Could you please help to adjust the text?

database/other/text-formatting.json Outdated Show resolved Hide resolved
Adjusted the text as per request.
Adjusted the text as per request.
Copy link
Contributor Author

@nelsonuprety1 nelsonuprety1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have adjusted the text as per @aftabrehan request. Thank You. 🙏

Copy link
Collaborator

@aftabrehan aftabrehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@nelsonuprety1
Copy link
Contributor Author

@Anmol-Baranwal @aftabrehan @CBID2 @rupali-codes hello if everything is okay with the PR i would like to request you guys to please merge the PR . Thank You

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@Anmol-Baranwal Anmol-Baranwal merged commit ee5c642 into rupali-codes:main Dec 4, 2023
7 checks passed
CBID2 added a commit to CBID2/My-version that referenced this pull request Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add] <A Card in Text Formatting>
4 participants